Issue 134 removing the no longer needed patch + adding integration tests #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #476 |
andrzejj0
force-pushed
the
issue-134-remove-patch
branch
4 times, most recently
from
267ed55
to
8fe726e
Compare
|
Looks like infrastructure problems again. Could you please relaunch the failed jobs? |
|
@slawekjaranowski please review |
andrzejj0
force-pushed
the
issue-134-remove-patch
branch
from
8fe726e
to
16bba7c
Compare
versions-maven-plugin/src/it/it-unlock-snapshots-issue-134/pom.xml
Outdated
Show resolved
Hide resolved
versions-maven-plugin/src/it/it-use-dep-version-issue-134/pom.xml
Outdated
Show resolved
Hide resolved
andrzejj0
force-pushed
the
issue-134-remove-patch
branch
from
16bba7c
to
34e2305
Compare
…etRawModel can be used instead. Adding more integration tests.
andrzejj0
force-pushed
the
issue-134-remove-patch
branch
from
34e2305
to
8fb889a
Compare
|
@slawekjaranowski please review |
rather replace - not waiting - I'm right? |
This was
linked to
issues
Nov 19, 2022
Not anymore. I meant to wait for the outcome of the discussion there. In other words, can be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the patch is no longer needed. Tested with maven 3.2.5 as well as 3.6.3. Added integration tests which test against the case described in the issue.
Some explanation.
The removed method extracted the imported dependencies from the raw model, which were then used in addition to dependencies from the imported boms, which were added by Maven.
But, because the dependencies added by Maven are not present in the POM to be updated, processing them is simply wasted resources. Instead, it's much better to just process the raw model.