Enable nested dict decoding #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most forks of this project change is_record(Term, dict, 8) to is_record(Term, dict, 9) to reflect the fact that apparently dict records are of size 9 in versions at least greater than R13B03 (seems to be the earliest complaint about the issue). I haven't verified that size 8 works prior to R13B03, but I'm guessing it did at one point. Assuming dicts will always be represented as tuples where the first element is the dict atom, this change would be version agnostic. Note that the tests are a bit coupled to the bert implementation, but with that you gain some documentation as to what it's actually encoding/decoding.
Moved from rake to rebar. Note that the tests have been changed to be OTP compliant, specifically following the m_tests.erl convention so they will be automatically picked up by eunit (see eunit overview, "Running EUnit")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently bert can only decode one-level dicts, this enables nested dict decoding.
Apologies for including 2 commits in this pull request, but I'm using a combination of laziness and judgment and assuming that the dict encoding fix is a given.