Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cucumber AND/OR tags properly #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomhicks-bsf
Copy link
Contributor

Multiple tags should be supplied in multiple --tags arguments,
which allows logical ORs and ANDs to be applied to tags. This
creates --tags arguments according to the cucumber docs:

https://github.com/cucumber/cucumber/wiki/Tags

tags: ['@one', '~@two'] will run scenarios with tag @one, but not
scenarios with tag @two.

@tomhicks-bsf
Copy link
Contributor Author

Fixes #334

Multiple tags should be supplied in multiple --tags arguments,
which allows logical ORs and ANDs to be applied to tags. This
creates --tags arguments according to the cucumber docs:

https://github.com/cucumber/cucumber/wiki/Tags

tags: ['@one', '~@two'] will run scenarios with tag @one, but not
scenarios with tag @two.
@sethkrasnianski
Copy link
Member

Looks good 👍. 👀 @samccone?

@samccone
Copy link
Contributor

samccone commented Oct 7, 2015

sure thing

@mAiNiNfEcTiOn
Copy link

You gotta be kidding me... I have a PR to fix this since July (#335) ... :/

Oh well...

@tomhicks-bsf
Copy link
Contributor Author

sorry, I didn't check that before opening this. EIther way, neither has been merged! How do we get pioneer support up and running again?

@mAiNiNfEcTiOn
Copy link

Yeah... good question ... :P @samccone might be super busy, but I have been using this project for quite a while (we have this on our CI)...

But due to this lack of support/maintenance I am very inclined to switch to other solutions (such as nightwatch) which have far more contributors, stars, and supporters.

Doesn't have gherkin... but I guess that is easily implementable :)

Oh, and no need to be sorry ... Just found interesting that you had feedback on the PR :P

@samccone
Copy link
Contributor

samccone commented Nov 4, 2015

Hey @mAiNiNfEcTiOn and @tomhicks-bsf I actually no longer work at this company and do not use this project anymore

perhaps @sethkrasnianski could help here 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants