Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cilppy warnings and MSRV CI for v0.9.x #293

Merged
merged 4 commits into from
Jul 29, 2023
Merged

Conversation

tatsuya6502
Copy link
Member

@tatsuya6502 tatsuya6502 commented Jul 29, 2023

Fix Clippy warnings

  • clippy 0.1.72 (a47f796a365 2023-07-22)
  • Add a cfg flag called clippy_beta to allow a lint when Clippy beta is used.
    • This is needed because the same lint is not available in Clippy stable.

Fix CI for the MSRV

When testing the MSRV (1.60.0) of moka 0.10.x, downgrade the following crates, so they will compile:

  • Downgrade dashmap to v5.4.0
  • Downgrade tempfile to v3.6.0.

clippy 0.1.72 (a47f796a365 2023-07-22)
clippy 0.1.72 (a47f796a365 2023-07-22)
When testing the MSRV, downgrade `tempfile` to v3.6.0 so that it will compile.
When testing the MSRV, downgrade `dashmap` to v5.4.0 so it will compile.
@tatsuya6502 tatsuya6502 self-assigned this Jul 29, 2023
@tatsuya6502 tatsuya6502 added this to the v0.9.9 milestone Jul 29, 2023
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 merged commit 26fad90 into maint-09 Jul 29, 2023
36 checks passed
@tatsuya6502 tatsuya6502 deleted the fix-ci-2023-07-v09 branch July 29, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant