-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the upsert and compute methods for modifying a cached entry #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatsuya6502
force-pushed
the
compute-api
branch
from
December 31, 2023 04:31
671c97d
to
781988c
Compare
of `future::Cache`
tatsuya6502
changed the title
Add the compute API for modifying a cached entry
Add the upsert and compute methods for modifying a cached entry
Jan 3, 2024
of `future::Cache`
Also update the change log.
access to the entry Also improve the docs and source code comments of the compute family methods.
`and_try_compute_with` methods
I changed the return types of
|
tatsuya6502
commented
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227, #353.
This PR adds compute family-methods to the
entry
API. They take a closure to insert, update, or remove a value for a key depending on the current cached value.Also bumps the version to
v0.12.3
.API:
future::Cache
Examples
See the following examples in the
examples
directory of thecompute-api
branch:and_upsert_with
method.u64
.and_compute_with
method.u64
but reset (remove) it when it is 2.and_upsert_with
method.i32
to a cachedArc<RwLock<Vec<i32>>>
.and_try_compute_with
method.char
and append to a cachedArc<RwLock<String>>
, but reading can fail by EOF.API:
sync::Cache
andsync::SegmentedCache
Tasks
future::Cache
:and_upsert_with
method. (upsert: insert or update)and_compute_with
method.and_try_compute_with
method.sync::Cache
,sync::SegmentedCache
:and_upsert_with
method. (upsert: insert or update)and_compute_with
method.and_try_compute_with
method.