Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin triomphe to keep the MSRV #426

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Pin triomphe to keep the MSRV #426

merged 2 commits into from
Jun 2, 2024

Conversation

eaufavor
Copy link
Contributor

This PR resolves #425

@tatsuya6502 tatsuya6502 self-requested a review May 30, 2024 00:39
tatsuya6502
tatsuya6502 requested changes May 30, 2024
View reviewed changes
Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR! I left a comment to re-add the lower version bound v0.1.3 to triomphe because cargo +nightly update -Z minimal-versions will pick up a too old version without it.

Cargo.toml Outdated Show resolved Hide resolved
@eaufavor @tatsuya6502
Update Cargo.toml
17ef6a9 
Co-authored-by: Tatsuya Kawano <[email protected]>
@eaufavor
Copy link
Contributor Author

Thanks!

tatsuya6502
tatsuya6502 approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks good to me.

@tatsuya6502 tatsuya6502 merged commit f3810e4 into moka-rs:main Jun 2, 2024
22 checks passed
@tatsuya6502 tatsuya6502 added this to the v0.12.8 milestone Jun 2, 2024
@RustyNova016
Copy link

Any ETA for the release? I got stumbled into this and it's mildly annoying to have to deal with a breaking change on a minor version

@tatsuya6502
Copy link
Member

Hi. Sorry for the delay. Hope I can release it in a day or so.

@tatsuya6502
Copy link
Member

I published v0.12.8 to crates.io.

@tatsuya6502 tatsuya6502 mentioned this pull request Jul 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatsuya6502 tatsuya6502 tatsuya6502 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.8
Development

Successfully merging this pull request may close these issues.

Latest triomphe update breaks MSRV
3 participants
@eaufavor @RustyNova016 @tatsuya6502