Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run miri using tree borrows in addition to the existing stacked borrows #454

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

tatsuya6502
Copy link
Member

Our CI runs miri on the following internal modules, which contain a bunch of unsafe codes.

  • deque
  • timer_wheel

And we have only used miri's stacked borrows model to detect pointer aliasing violations.

This pull request adds miri tests using tree borrows model so that our CI will detect the problems like the one reported by #452.

https://github.com/moka-rs/moka/actions/runs/10545853093/job/29216602204
miri-tree-borrows

@tatsuya6502 tatsuya6502 added this to the v0.12.9 milestone Aug 25, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (c5e5ba3) to head (63f8928).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          44       44           
  Lines       20938    20938           
=======================================
  Hits        19874    19874           
  Misses       1064     1064           

Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 merged commit a4171b2 into main Aug 25, 2024
39 checks passed
@tatsuya6502 tatsuya6502 deleted the miri-tree-borrows branch August 25, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant