Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout change and show/hide functionality #46

Closed
wants to merge 1 commit into from

Conversation

milenmk
Copy link

@milenmk milenmk commented Jun 30, 2024

I wasn't delighted with the default layout, so I've made some changes to make it look better.

Main changes

  • The layout is now responsive. All columns fit to page width.
  • Changed the background for the columns to white and the records to grey
  • The status title is now inside the container
  • When using enums, if colour and icon are defined they will be visible
  • Script to show/hide columns

With this modification, the look is like this:

Default

Screenshot 2024-06-30 175805

With hidden columns

Screenshot 2024-06-30 173705

  • When a user clicks on the icon of a hidden column, the column will reappear and the record will be removed from the hidden items list

Hope you like it.

P.S.: I have invited you as collaborator to the forked repository

Added script to show/hide columns
@willcastillo
Copy link

Nicely done @milenmk ! hope it gets added soon!

@aeq-dev
Copy link

aeq-dev commented Sep 28, 2024

Any updates here 👁️

@mokhosh
Copy link
Owner

mokhosh commented Sep 28, 2024

This is generally a nice idea. However, there are quite a few issues that prevent me from merging this:

  1. The PR is to main branch, which means this will only be available in v3, which has no ETA as of now.
  2. There are unnecessary changes to code style which makes the diff very untidy.
  3. There are style issues, which can hopefully be fixed by running pint.
  4. The code doesn't follow the current style of the repo. For example you're using vanilla js even though the project is using alpine.
  5. There are bad decisions like putting onclick on a div.
  6. The PR is from main branch. So, I can't edit your PR.

I'll be happy to merge a new PR with these issues fixed. Otherwise I will try to adopt as much as I can in v3.

@mokhosh mokhosh closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants