Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom stub file to be used for board. #57

Closed
wants to merge 1 commit into from

Conversation

Cybrarist
Copy link

allow custom stub file for board.

the custom path will be in /stubs/filament-kanban/board.stub. if custom file not found then we use the default one.

allow custom stub file for board.

the custom path will be /stubs/filament-kanban/board.stub, if not found then we use the default one.
@mokhosh
Copy link
Owner

mokhosh commented Sep 26, 2024

Thanks for the PR, but if you want this to be included in v2 you'll have to PR against the v2 branch.
The main branch has moved and will be present in v3.

Also, please make these changes:

  1. Make sure to fix the styling. You can run pint for this.
  2. Get rid of the $stub variable and inline it.
  3. Get rid of the trim function since this method is not dynamic.

Thanks

@mokhosh mokhosh closed this Sep 26, 2024
@Cybrarist Cybrarist deleted the patch-1 branch October 1, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants