Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resume stream after all chunks are published to prevent memory leak
📝 Description
Memory leak scenario: we have two machines with each deployed a node. We use molecularr-web as a proxy to implement the file upload function. The files are first sent to the gateway and then forwarded to the service on the other machine using streams.
However, due to the file storage speed being slower than the internal network speed between the two machines, data starts to accumulate in the gateway.
As we had not handled this situation correctly before, it caused significant memory leaks in our production environment when users uploaded files. I identified the issue and fixed it.
🎯 Relevant issues
None.
💎 Type of change
🚦 How Has This Been Tested?
As the description above
🏁 Checklist: