fix: Fix false positive in plugin application discovery (argoproj#20196)

* fix: fix false positive in plugin application discovery Signed-off-by: Pradithya Aria <[email protected]> * fix: apply suggestion to return immediately if discovery is not configured for unnamed plugin Signed-off-by: Pradithya Aria <[email protected]> --------- Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: Moleus <[email protected]>
moleus · Oct 7, 2024 · 0f518a8 · 0f518a8
1 parent a02246a
commit 0f518a8
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/util/app/discovery/discovery.go b/util/app/discovery/discovery.go
@@ -173,9 +173,12 @@ func cmpSupports(ctx context.Context, pluginSockFilePath, appPath, repoPath, fil
 		return nil, nil, false
 	}
 
-	// if discovery is not configured, return the client without further checks
 	if !cfg.IsDiscoveryConfigured {
-		return conn, cmpClient, true
+		// If discovery isn't configured but the plugin is named, then the plugin supports the repo.
+		if namedPlugin {
+			return conn, cmpClient, true
+		}
+		return nil, nil, false
 	}
 
 	isSupported, isDiscoveryEnabled, err := matchRepositoryCMP(ctx, appPath, repoPath, cmpClient, env, tarExcludedGlobs)