Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for tabulated angle potentials #44

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Added support for tabulated angle potentials #44

merged 3 commits into from
Aug 28, 2023

Conversation

paulsaxe
Copy link
Collaborator

No description provided.

@paulsaxe paulsaxe added the enhancement New feature or request label Aug 27, 2023
@paulsaxe paulsaxe requested a review from seamm August 27, 2023 20:05
@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch coverage: 4.87% and project coverage change: -0.12% ⚠️

Comparison is base (0101cf2) 15.56% compared to head (071d790) 15.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   15.56%   15.45%   -0.12%     
==========================================
  Files          33       33              
  Lines        3090     3126      +36     
==========================================
+ Hits          481      483       +2     
- Misses       2609     2643      +34     
Flag Coverage Δ
unittests 15.45% <4.87%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lammps_step/initialization.py 8.41% <0.00%> (-0.14%) ⬇️
lammps_step/lammps.py 6.38% <5.88%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seamm seamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seamm seamm merged commit 3a9bc6e into main Aug 28, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants