Skip to content

Commit

Permalink
Merge pull request #150 from molssi-seamm/dev
Browse files Browse the repository at this point in the history
Bugfix: keeping the current name when updating a system.
  • Loading branch information
seamm authored Sep 27, 2023
2 parents 7ff4dca + 92647ed commit c78271c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
3 changes: 3 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
=======
History
=======
2023.9.26.1 -- Bugfix: system naming
* Fixed a bug with keeping the current name when updating a system.

2023.9.26 -- Added units to header in tables, and bugfixes.
* The headers for table columns now include units when generated automatically when
writing results. Existing columns are not changed.
Expand Down
4 changes: 2 additions & 2 deletions seamm/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ def get_system_configuration(

# Attend to naming
if "system name" in P:
if P["system name"] == "current name":
if P["system name"] == "keep current name":
pass
elif P["system name"] == "use SMILES string":
system.name = configuration.smiles
Expand All @@ -563,7 +563,7 @@ def get_system_configuration(
else:
system.name = str(P["system name"]).format(**kwargs)
if "configuration name" in P:
if P["configuration name"] == "current name":
if P["configuration name"] == "keep current name":
pass
elif P["configuration name"] == "use SMILES string":
configuration.name = configuration.smiles
Expand Down
3 changes: 1 addition & 2 deletions seamm/standard_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,10 @@
),
},
"system name": {
"default": "from file",
"default": "keep current name",
"kind": "string",
"default_units": "",
"enumeration": (
"from file",
"keep current name",
"use SMILES string",
"use Canonical SMILES string",
Expand Down

0 comments on commit c78271c

Please sign in to comment.