Skip to content

Commit

Permalink
Added comments to highlight a dimensionally problematic constant
Browse files Browse the repository at this point in the history
- Per feedback to #1156
  • Loading branch information
adcroft committed Jul 10, 2020
1 parent ee1232a commit f0bab12
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/ALE/PLM_functions.F90
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ real elemental pure function PLM_slope_wa(h_l, h_c, h_r, h_neglect, u_l, u_c, u_
endif

! An attempt to avoid inconsistency when the values become unrepresentable.
! ### The following 1.E-140 is dimensionally inconsistent. A newer version of
! PLM is progress that will avoid the need for such rounding.
if (abs(PLM_slope_wa) < 1.E-140) PLM_slope_wa = 0.

end function PLM_slope_wa
Expand Down Expand Up @@ -104,6 +106,8 @@ real elemental pure function PLM_slope_cw(h_l, h_c, h_r, h_neglect, u_l, u_c, u_
endif

! An attempt to avoid inconsistency when the values become unrepresentable.
! ### The following 1.E-140 is dimensionally inconsistent. A newer version of
! PLM is progress that will avoid the need for such rounding.
if (abs(PLM_slope_cw) < 1.E-140) PLM_slope_cw = 0.

end function PLM_slope_cw
Expand Down

0 comments on commit f0bab12

Please sign in to comment.