Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic: thkcello #98

Closed
jkrasting opened this issue Mar 30, 2015 · 3 comments
Closed

Add diagnostic: thkcello #98

jkrasting opened this issue Mar 30, 2015 · 3 comments

Comments

@jkrasting
Copy link
Contributor

Add the 'thkcello' diagnostic. Note that the vertical remapping process will complicate this as thkcello will become time-dependent.

For now, this diagnostic should be based on 'h' and follow the convention:

cmor_field_name='thkcello', cmor_long_name='Ocean Model Cell Thickness', cmor_units='m', cmor_standard_name='cell_thickness'

@jkrasting jkrasting added this to the CMOR-ization of diagnostics milestone Mar 30, 2015
@jkrasting
Copy link
Contributor Author

In the event that h is not in m, such as in non-Boussinesq mode where h is in kg m-2, will need to calculate in in-situ density and divide.

@StephenGriffies
Copy link
Contributor

The conversion factor, G%H_to_m, is a constant, 1/Rho0. In fact, we need to divide by the in situ density to get a proper accounting of the thickness of a grid cell for the non-Boussinesq model. So your placement of G%H_to_m does the proper unit conversion. Yet it will not provide a proper accounting of the steric changes in a fluid column.

That is, the vertical sum of G%H_to_m*h will not equal to the total ocean depth (bathymetry + sea surface height). Instead, we need to divide by the in situ density at each time step to properly compute the grid cell thickness in a non-Bouss model.

I propose we keep your code change as a placeholder. But if we move to non-Boussinesq for CMIP6, we need to address this issue regarding the need to divide by in situ density. I thus recommend we keep the smg: comment in the code, and keep this issue open on Github.

adcroft added a commit that referenced this issue Apr 27, 2015
- Corrected calculation of thkcello, cell thickness in meters,
  for non-Boussinesq mode.
- Moved diagnostic of thkcello into MOM_diagnostics.F90 from
  MOM.F90.
- Renamed a temporary 3d array which is re-used by various
  diagnostics.
- Closes issue #98.
@adcroft
Copy link
Collaborator

adcroft commented Apr 28, 2015

Closed by commit ad5aab0 and PR #150.

@adcroft adcroft closed this as completed Apr 28, 2015
gustavo-marques added a commit to gustavo-marques/MOM6 that referenced this issue May 10, 2019
MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/MOM6 that referenced this issue Jun 15, 2021
jiandewang referenced this issue in jiandewang/MOM6 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants