Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Explicit OpenMP CPU affinity #1150

Merged
merged 2 commits into from
Jul 6, 2020

Conversation

marshallward
Copy link
Collaborator

FMS affinity operations, often used in OpenMP directives, require
explicit CPU affinities such that the number of available CPUs matches
the number of requested PEs.

To accommodate this, we explicit configure OpenMP to use cpu=0 for our
ARM tests.

FMS affinity operations, often used in OpenMP directives, require
explicit CPU affinities such that the number of available CPUs matches
the number of requested PEs.

To accommodate this, we explicit configure OpenMP to use cpu=0 for our
ARM tests.
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020

Codecov Report

Merging #1150 into dev/gfdl will decrease coverage by 0.30%.
The diff coverage is 33.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1150      +/-   ##
============================================
- Coverage     46.08%   45.78%   -0.31%     
============================================
  Files           214      223       +9     
  Lines         69399    69835     +436     
============================================
- Hits          31984    31972      -12     
- Misses        37415    37863     +448     
Impacted Files Coverage Δ
...g_src/external/GFDL_ocean_BGC/FMS_coupler_util.F90 0.00% <0.00%> (ø)
...fig_src/external/GFDL_ocean_BGC/generic_tracer.F90 0.00% <0.00%> (ø)
...c/external/GFDL_ocean_BGC/generic_tracer_utils.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/kdtree.f90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_core.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/ocean_da_types.F90 0.00% <0.00%> (ø)
config_src/external/ODA_hooks/write_ocean_obs.F90 0.00% <0.00%> (ø)
config_src/solo_driver/MESO_surface_forcing.F90 0.00% <0.00%> (ø)
config_src/solo_driver/user_surface_forcing.F90 0.00% <0.00%> (ø)
src/ALE/MOM_regridding.F90 31.63% <0.00%> (ø)
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1bef0...14d4cda. Read the comment docs.

@Hallberg-NOAA
Copy link
Collaborator

This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/10760.

@marshallward
Copy link
Collaborator Author

@Hallberg-NOAA This does not change the source code, so should not need a Gaea test.

@Hallberg-NOAA Hallberg-NOAA merged commit 56ec441 into mom-ocean:dev/gfdl Jul 6, 2020
@marshallward marshallward deleted the omp_affinity_test branch September 2, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants