OBC: H-dimensionality fixes #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes three dimensionality errors in the OBC segments. - We add a missing GV%m_to_H conversion for time-dependent eta segments. - The `adjustSegmentEtaToFitBathymetry` function depends on the `segment%Htot` field when computing the dz_src cell spacings. While the calculation primarily assumes that all quantities scale as Z, the segment%Htot field scales as H, which was causing dimensionality errors. We resolve this by converting Htot from Z to H whenever it is used in the calculation. - Segment barotropic velocitys based on transports were limited to a hard-coded thickness of 1e-12, which was not scaled. We have added H-dimensional scaling to these constants.
marshallward
force-pushed
the
tc4a_dimh_bug
branch
from
e337192
to
16a0a06
Compare
|
I did a force push to the commit log, which forgot to mention this third change:
|
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1170 +/- ##
============================================
- Coverage 46.08% 45.94% -0.14%
============================================
Files 214 224 +10
Lines 69399 70431 +1032
============================================
+ Hits 31984 32363 +379
- Misses 37415 38068 +653
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
These changes are both necessary and correct. They have passed all testing, including pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/10896. I am happy to approve these changes.
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes two dimensionality errors in the OBC segments.
We add a missing
GV%m_to_Hconversion for time-dependent eta segments.The
adjustSegmentEtaToFitBathymetryfunction depends on thesegment%Htotfield when computing thedz_srccell spacings.While the calculation primarily assumes that all quantities scale as
Z, thesegment%Htotfield scales asH, which was causingdimensionality errors.
We resolve this by converting
HtotfromZtoHwhenever it is used inthe calculation.