+Revised interface to write_cputime #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised the interface to write_cputime, adding one optional argument and making another intent inout argument optional when it was not going to be reset, and also adding a flush of an I/O channel, and added a new subroutine, MOM_write_cputime_end, to be called during cleanup, potentially via write_cputime. The write_cputime calls from the solo driver routines have been modified in accord with these changes, and a final write_cputime call has been added so that the time used by the whole run is reported. These changes should address the problems in MOM6 issue mom-ocean#853, which should be closed once this PR is merged into dev/gfdl. All answers are bitwise identical, but there are minor interface changes and a new publicly visible subroutine.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1189 +/- ##
============================================
- Coverage 46.08% 46.02% -0.06%
============================================
Files 214 224 +10
Lines 69399 70511 +1112
============================================
+ Hits 31984 32456 +472
- Misses 37415 38055 +640
Continue to review full report at Codecov.
|
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the interface to write_cputime, adding one optional argument and
making another intent inout argument optional when it was not going to be reset,
and also adding a flush of an I/O channel, and added a new subroutine,
MOM_write_cputime_end, to be called during cleanup, potentially via
write_cputime. The write_cputime calls from the solo driver routines have been
modified in accord with these changes, and a final write_cputime call has been
added so that the time used by the whole run is reported. These changes should
address the problems in MOM6 issue #853, which should be closed once this PR is
merged into dev/gfdl. All answers are bitwise identical, but there are minor
interface changes and a new publicly visible subroutine.