Diagnostics for depth-averaged acceleration from diapycnal mixing #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1217 +/- ##
============================================
- Coverage 46.08% 46.08% -0.01%
============================================
Files 214 224 +10
Lines 69399 70645 +1246
============================================
+ Hits 31984 32556 +572
- Misses 37415 38089 +674
Continue to review full report at Codecov.
|
Changed the default for SPONGE_IDAMP_VAR from "IDAMP" to "Idamp" so that when this variable is used, as it would be with the proposed change, it does not break any existing experiments. This could change some MOM_parameter_doc files, but will not change any solutions because the variable whose default is being set was not in use.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1217 +/- ##
============================================
+ Coverage 46.08% 46.13% +0.05%
============================================
Files 214 224 +10
Lines 69399 70997 +1598
============================================
+ Hits 31984 32757 +773
- Misses 37415 38240 +825
Continue to review full report at Codecov.
|
|
The pipeline testing for this PR can be found at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11387. |
|
Passes up to a parameter update. |
marshallward
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding to 2D fractional-thickness weighted momentum budget diagnostics, diagnostics for zonal and meridional acceleration terms from diapycnal mixing have been added.
Plus a small correction in read_data call for
Idampin sponge initialization.