Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo correction #1345

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Typo correction #1345

merged 2 commits into from
Mar 5, 2021

Conversation

hmkhatri
Copy link
Contributor

@hmkhatri hmkhatri commented Mar 5, 2021

In many array allocations, I had used Jsd instead of JsdB for indices in many places. It might be irrelevant but I have made the correction anyway.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #1345 (e9fdff2) into dev/gfdl (b57431d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1345   +/-   ##
=========================================
  Coverage     45.82%   45.82%           
=========================================
  Files           234      234           
  Lines         72661    72661           
=========================================
  Hits          33300    33300           
  Misses        39361    39361           
Impacted Files Coverage Δ
src/core/MOM_CoriolisAdv.F90 67.57% <100.00%> (ø)
src/core/MOM_dynamics_split_RK2.F90 89.73% <100.00%> (ø)
src/diagnostics/MOM_diagnostics.F90 87.86% <100.00%> (ø)
...parameterizations/vertical/MOM_diabatic_driver.F90 63.96% <100.00%> (ø)
...c/parameterizations/vertical/MOM_vert_friction.F90 74.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57431d...075be64. Read the comment docs.

Copy link
Collaborator

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct.

I find it interesting though that we have no way to verify that the bounds of an array are correct if we do not actually use the entire bounds.

@marshallward marshallward self-assigned this Mar 5, 2021
@marshallward
Copy link
Collaborator

marshallward commented Mar 5, 2021

@marshallward marshallward merged commit e7a80bc into mom-ocean:dev/gfdl Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants