Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: FGNV streamfunction vertical bounds #1346

Merged
merged 2 commits into from
Mar 13, 2021

Commits on Mar 6, 2021

  1. Bugfix: FGNV streamfunction vertical bounds

    This patch fixes an issue with the vertical array bounds of the Ferrari
    et al. streamfunction.  The array is bounded across interfaces, from 1
    to nz+1, but only the interior values need to be determined due to the
    arbitrary boundary value (set here to zero).
    
    In the current source, the streamfunction is rescaled before calling
    streamfn_solver, but need not be applied to the boundary values.  This
    is unlikely to cause errors in production, since the values are later
    reset to zero, but the rescaling can raise errors in more aggressive
    debugging builds, such as when the arrays are initialized with NaN
    values.
    marshallward committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    651b467 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Configuration menu
    Copy the full SHA
    33d28f1 View commit details
    Browse the repository at this point in the history