Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: empty restart_input_dir for *_solo.res #1348

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

herrwang0
Copy link
Contributor

The ocean/ice solo drivers look for "ocean_solo.res" and "ice_solo.res" in dirs%restart_input_dir. However, dirs is only initiated after the call of file_exist for the ".res" files.

This PR fixes this issue (https://github.com/NOAA-GFDL/MOM6/issues/1313) by moving get_MOM_input in ice_self_driver.F90 and adding an additional get_MOM_input in MOM_driver.F90, respectively.

This commit fixes the issue that dirs%restart_input_dir is not initiated before
"ocean_solo.res" and "ice_solo.res" are read.
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #1348 (5b293ef) into dev/gfdl (e7a80bc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1348   +/-   ##
=========================================
  Coverage     45.82%   45.83%           
=========================================
  Files           234      234           
  Lines         72661    72662    +1     
=========================================
+ Hits          33300    33301    +1     
  Misses        39361    39361           
Impacted Files Coverage Δ
config_src/solo_driver/MOM_driver.F90 68.82% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a80bc...5b293ef. Read the comment docs.

Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that these changes to correct the problem identified in Issue #1313, and that they are the right solution.

@marshallward
Copy link
Collaborator

marshallward commented Mar 9, 2021

@marshallward marshallward merged commit 1b05969 into mom-ocean:dev/gfdl Mar 9, 2021
@herrwang0 herrwang0 deleted the fix-ocean_solo-res-dir branch September 18, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants