-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only write checksums from root PE for FMS_cap #1353
Only write checksums from root PE for FMS_cap #1353
Conversation
Modified the routines that write out the checksums of various types related to the surface ocean state so that only the root PE writes the checksums. The modified routines are ocn_ice_bnd_type_chksum and ocean_public_type_chksum in config_src/infra/FMS_cap. The analogous routines with the nuopc_cap and mct_cap have not been modified; although doing so would be a very good idea, it should be done by someone who is actively testing them. In some large-PE tests cases this reduces the volume of output to stdout by over 90% without any loss of information. All solutions are bitwise identical, but there may be minor white-space reformatting of the output in some cases.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1353 +/- ##
=========================================
Coverage 45.82% 45.82%
=========================================
Files 234 234
Lines 72667 72667
=========================================
Hits 33302 33302
Misses 39365 39365 Continue to review full report at Codecov.
|
@Hallberg-NOAA, I have done the same modifications in the analogous routines from the NUOPC and MCT caps. I will send a PR to
|
Only write checksums from root PE MCT/NUOPC caps
This PR passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12344, and Alistair has already reviewed and approved this PR. |
Modified the routines that write out the checksums of various types related to
the surface ocean state so that only the root PE writes the checksums. The
modified routines are ocn_ice_bnd_type_chksum and ocean_public_type_chksum in
config_src/infra/FMS_cap. The analogous routines with the nuopc_cap and mct_cap
have not been modified; although doing so would be a very good idea, it should
be done by someone who is actively testing them. In some large-PE tests cases
this reduces the volume of output to stdout by over 90% without any loss of
information. All solutions are bitwise identical, but there may be minor
white-space reformatting of the output in some cases.