Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only write checksums from root PE for FMS_cap #1353

Merged
merged 4 commits into from
Mar 27, 2021

Conversation

Hallberg-NOAA
Copy link
Collaborator

Modified the routines that write out the checksums of various types related to
the surface ocean state so that only the root PE writes the checksums. The
modified routines are ocn_ice_bnd_type_chksum and ocean_public_type_chksum in
config_src/infra/FMS_cap. The analogous routines with the nuopc_cap and mct_cap
have not been modified; although doing so would be a very good idea, it should
be done by someone who is actively testing them. In some large-PE tests cases
this reduces the volume of output to stdout by over 90% without any loss of
information. All solutions are bitwise identical, but there may be minor
white-space reformatting of the output in some cases.

  Modified the routines that write out the checksums of various types related to
the surface ocean state so that only the root PE writes the checksums.  The
modified routines are ocn_ice_bnd_type_chksum and ocean_public_type_chksum in
config_src/infra/FMS_cap.  The analogous routines with the nuopc_cap and mct_cap
have not been modified; although doing so would be a very good idea, it should
be done by someone who is actively testing them.  In some large-PE tests cases
this reduces the volume of output to stdout by over 90% without any loss of
information.  All solutions are bitwise identical, but there may be minor
white-space reformatting of the output in some cases.
@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

Merging #1353 (2693e66) into dev/gfdl (8dd9072) will not change coverage.
The diff coverage is n/a.

❗ Current head 2693e66 differs from pull request most recent head 2579d07. Consider uploading reports for the commit 2579d07 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1353   +/-   ##
=========================================
  Coverage     45.82%   45.82%           
=========================================
  Files           234      234           
  Lines         72667    72667           
=========================================
  Hits          33302    33302           
  Misses        39365    39365           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd9072...2579d07. Read the comment docs.

@gustavo-marques
Copy link
Collaborator

@Hallberg-NOAA, I have done the same modifications in the analogous routines from the NUOPC and MCT caps. I will send a PR to Hallberg-NOAA:less_checksums soon.
I then verified that we get bit for bit answers against dev/gfdl. The following tests were performed:

  • SMS_D_Vnuopc.T62_t061.GMOM_IAF.cheyenne_intel
  • SMS_D_Ld2.T62_g16.CMOM.cheyenne_gnu.

Only write checksums from root PE MCT/NUOPC caps
@Hallberg-NOAA
Copy link
Collaborator Author

This PR passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12344, and Alistair has already reviewed and approved this PR.

@Hallberg-NOAA Hallberg-NOAA merged commit 67b03e3 into mom-ocean:dev/gfdl Mar 27, 2021
@Hallberg-NOAA Hallberg-NOAA deleted the less_checksums branch July 30, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants