Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to commit 893a06e062 which broke the SIGMA_SHELF_ZSTAR option #1459

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

MJHarrison-GFDL
Copy link
Contributor

  • Testing with an ice shelf (e.g. ISOMIP) and using
    the SIGMA_SHELF_ZSTAR coordinate would have caught this bug.

MJHarrison-GFDL and others added 2 commits August 3, 2021 15:31
  - Testing with an ice shelf (e.g. ISOMIP) and using
    the SIGMA_SHELF_ZSTAR coordinate would have caught this bug.
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #1459 (360eb2f) into dev/gfdl (3a0725d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 360eb2f differs from pull request most recent head bf34a57. Consider uploading reports for the commit bf34a57 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1459   +/-   ##
=========================================
  Coverage     29.30%   29.30%           
=========================================
  Files           234      234           
  Lines         70600    70600           
=========================================
  Hits          20686    20686           
  Misses        49914    49914           
Impacted Files Coverage Δ
src/ALE/MOM_regridding.F90 21.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0725d...bf34a57. Read the comment docs.

@marshallward
Copy link
Collaborator

@marshallward marshallward merged commit bc99ba2 into mom-ocean:dev/gfdl Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants