-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOM6: +Preparations to allow reference heights to change #1467
MOM6: +Preparations to allow reference heights to change #1467
Commits on Aug 15, 2021
-
+Add optional dZref argument to find_eta
Added an optional dZref argument to the two find_eta routines so that the bathymetry can use a different reference height than is used for the interface heights. By default, they use the same reference height and all answers are bitwise identical. There is a new optional arguments (that is not yet being exercised with this commit, but has been tested and will be used in an upcoming commit) to two publicly visible interfaces.
Configuration menu - View commit details
-
Copy full SHA for 6f1a191 - Browse repository at this point
Copy the full SHA 6f1a191View commit details -
Code cleanup in MOM_regridding
Eliminated the depth argument to check_grid_column, along with some internal calculations that are never used. Also corrected some comments. All answers are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for a2df3b7 - Browse repository at this point
Copy the full SHA a2df3b7View commit details -
Longer error string in get_polynomial_coordinate
Lengthened a message string in get_polynomial_coordinate so that it will give a valid fatal error message in some cases of failures rather than resulting a segmentation fault with no message output. All answers are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for db43b35 - Browse repository at this point
Copy the full SHA db43b35View commit details -
+Add optional Z_0p argument to int_density_dz
Added an optional Z_0p argument to the various Boussinesq density integral routines as a new intercept for the linear expression between the (arbitrary) interface heights and pressure used for the equation of state routines. If omitted, this is equivalent to setting this intercept to 0, and all answers are bitwise identical. There are new optional arguments to several publicly visible interfaces (that are not yet being exercised with this commit, but have been tested and will be used in an upcoming commit).
Configuration menu - View commit details
-
Copy full SHA for 4d8d7af - Browse repository at this point
Copy the full SHA 4d8d7afView commit details -
Corrects the routine indicated in 2 error messages
Corrected error messages to indicate the right subroutine in rescale_dyn_horgrid_bathymetry. All answers are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for e4ffa76 - Browse repository at this point
Copy the full SHA e4ffa76View commit details -
Prep initialization for reference height changes
Added the optional argument dZ_ref_eta to adjustEtaToFitBathymetry so that the bathymetry can use a different reference height than is used in this routine. Also changed the name and reversed the sign of the depth (now Z_bot) argument to find_interfaces, and a new Z_bottom array in MOM_temp_salt_initialize_from_Z. An extra unit conversion factor was eliminated from MOM_state_init_tests. All answers are bitwise identical, and all of these changes are internal to this module.
Configuration menu - View commit details
-
Copy full SHA for 7cc0582 - Browse repository at this point
Copy the full SHA 7cc0582View commit details -
Cleanup of comments in MOM_ALE_sponge.F90
Extensive inconsequential cleanup in MOM_ALE_sponge.F90, including the elimination of a dozen unnecessary index-range elements of the ALE_sponge_CS and modifying a number of comments to be much more descriptive. This included the correction of numerous spelling errors and other typos in comments. All answers are bitwise identical.
Configuration menu - View commit details
-
Copy full SHA for 62446ec - Browse repository at this point
Copy the full SHA 62446ecView commit details -
(*)Fix dimensionally inconsistent MEKE beta calcs
Corrected dimensional inconsistencies in the negligible thicknesses in the denominators of the expressions for the topographic betas in MEKE_equilibrium and MEKE_lengthScales. This could change answers in strange cases, but seems unlikely to do so (partly because it is in a max expression, and not added), and did not change any answers in the MOM6-examples test suite.
Configuration menu - View commit details
-
Copy full SHA for c72d441 - Browse repository at this point
Copy the full SHA c72d441View commit details -
Added comments highlighting bugs
Added comments denoted with "###" indicating bugs or conceptual errors in update_OBC_segment_data, horizontal_viscosity, thickness_diffuse and wave_speed. Only comments and the case of some indices are changed in this commit, and all answers are bitwise identical. Actually correcting these bugs would probably change answers in some cases.
Configuration menu - View commit details
-
Copy full SHA for 5017bf6 - Browse repository at this point
Copy the full SHA 5017bf6View commit details
Commits on Aug 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 23d0076 - Browse repository at this point
Copy the full SHA 23d0076View commit details