Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ice dynamics #1479

Merged
merged 13 commits into from
Sep 1, 2021
Merged

Ice dynamics #1479

merged 13 commits into from
Sep 1, 2021

Conversation

OlgaSergienko
Copy link
Contributor

This PR includes several changes in ice dynamics initialization procedure in initialize_ice_shelf_dyn(); diagnostics output in ice_shelf_solve_outer(); velocity masks at the boundaries in update_velocity_masks(); and initialize_ice_thickness_from_file(). These changes do not affect solutions.

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #1479 (d234258) into dev/gfdl (bab9c91) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1479      +/-   ##
============================================
- Coverage     29.04%   29.04%   -0.01%     
============================================
  Files           236      236              
  Lines         71391    71398       +7     
============================================
  Hits          20736    20736              
- Misses        50655    50662       +7     
Impacted Files Coverage Δ
src/ice_shelf/MOM_ice_shelf_dynamics.F90 0.00% <0.00%> (ø)
src/ice_shelf/MOM_ice_shelf_initialize.F90 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98b76d...d234258. Read the comment docs.

@marshallward
Copy link
Collaborator

marshallward commented Sep 1, 2021

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13513 ✔️

Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the TC and pipeline testing are complete, I think that this PR is ready to go.

@marshallward marshallward merged commit a7d8e3a into mom-ocean:dev/gfdl Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants