(*)Fix discretization issues with USE_GME=True #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the inconsistently staggered expressions for the total depths used to scale away the GM+E backscatter scheme that is enabled with USE_GME. As a part of these changes, the nominal bathymetric depths have been replaced by the sum of the layer thicknesses, and parentheses were added to some of the GME expressions so that they will be rotationally invariant. Although there are no changes to the answers in the MOM6-examples test suite, answers will change in any cases where USE_GME is true, and GME_H0 is larger than the minimum ocean depth. This commit will address MOM6 issue mom-ocean#1466, which can now be closed.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1481 +/- ##
============================================
- Coverage 29.13% 29.13% -0.01%
============================================
Files 235 235
Lines 71061 71077 +16
============================================
+ Hits 20707 20711 +4
- Misses 50354 50366 +12
Continue to review full report at Codecov.
|
|
Thanks for fixing these issues, @Hallberg-NOAA. These changes do not affect the CESM/MOM6 tests -- currently, we do not have any example with |
gustavo-marques
approved these changes
Aug 27, 2021
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13477 ✔️ |
marshallward
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the inconsistently staggered expressions for the total depths used
to scale away the GM+E backscatter scheme that is enabled with USE_GME. As a
part of these changes, the nominal bathymetric depths have been replaced by the
sum of the layer thicknesses, and parentheses were added to some of the GME
expressions so that they will be rotationally invariant. Although there are no
changes to the answers in the MOM6-examples test suite, answers will change in
any cases where USE_GME is true, and GME_H0 is larger than the minimum ocean
depth. This commit will address MOM6 issue #1466, which can now be closed.