(*+)New internal tide bathymetric parameters #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the nominal bathymetric depth with the sum of the layer thicknesses in the calculation of the quadratic drag acting on the internal wave field. Also replaced the hard-coded 1 m scale at which the drag is reduced with a new runtime parameter, INTERNAL_TIDE_DRAG_MIN_DEPTH, which is only logged if the internal tides are used and INTERNAL_TIDE_QUAD_DRAG=True, and made the maximum scale of the topographic roughness as a fraction of the bottom depth into the new runtime parameter INTERNAL_TIDE_ROUGHNESS_FRAC, whose default, 0.1, is the same as the previous hard-coded value. Several of the comments in the MOM_internal_tides module were also clarified or standardized. All answers in the MOM-examples test suite are bitwise identical, but answers could change and there could be changes in the MOM_parameter_doc files in some cases that use the internal tides module.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1483 +/- ##
============================================
- Coverage 29.14% 29.13% -0.01%
============================================
Files 235 235
Lines 71081 71092 +11
============================================
Hits 20713 20713
- Misses 50368 50379 +11
Continue to review full report at Codecov.
|
raphaeldussin
approved these changes
Aug 27, 2021
marshallward
approved these changes
Aug 30, 2021
|
Gaea Regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the nominal bathymetric depth with the sum of the layer thicknesses
in the calculation of the quadratic drag acting on the internal wave field.
Also replaced the hard-coded 1 m scale at which the drag is reduced with a new
runtime parameter, INTERNAL_TIDE_DRAG_MIN_DEPTH, which is only logged if the
internal tides are used and INTERNAL_TIDE_QUAD_DRAG=True, and made the maximum
scale of the topographic roughness as a fraction of the bottom depth into the
new runtime parameter INTERNAL_TIDE_ROUGHNESS_FRAC, whose default, 0.1, is the
same as the previous hard-coded value. Several of the comments in the
MOM_internal_tides module were also clarified or standardized. All answers in
the MOM-examples test suite are bitwise identical, but answers could change and
there could be changes in the MOM_parameter_doc files in some cases that use the
internal tides module.