(*)Avoid uninitialized data use in find_interfaces #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified find_interfaces to avoid using uninitialized data when there is no input data in a column or only one layer of data and linear interpolation is nonsensical. This could change the initial conditions in some layer-mode cases, but in practice all solutions in the MOM6-examples test suite are bitwise identical, even though temporarily inserted error messages reveal that the conditions that triggered the modified code are being encountered.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1493 +/- ##
============================================
- Coverage 29.04% 29.03% -0.01%
============================================
Files 236 236
Lines 71401 71407 +6
============================================
Hits 20736 20736
- Misses 50665 50671 +6
Continue to review full report at Codecov.
|
marshallward
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified find_interfaces to avoid using uninitialized data when there is no
input data in a column or only one layer of data and linear interpolation is
nonsensical. This could change the initial conditions in some layer-mode cases,
but in practice all solutions in the MOM6-examples test suite are bitwise
identical, even though temporarily inserted error messages reveal that the
conditions that triggered the modified code are being encountered.