Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use allocate with source to initialize arrays #1499

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

Hallberg-NOAA
Copy link
Collaborator

Use the allocate call's source optional argument to initialize 611 arrays in
62 files. This change simplifies and shortens the code and will make it easier
to identify uninitialized allocated arrays. This change was only made to arrays
that were already being initialized on the same line as the allocate or shortly
thereafter. All answers are bitwise identical.

  Use the allocate call's source optional argument to initialize 611 arrays in
62 files.  This change simplifies and shortens the code and will make it easier
to identify uninitialized allocated arrays.  This change was only made to arrays
that were already being initialized on the same line as the allocate or shortly
thereafter.  All answers are bitwise identical.
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #1499 (55876e8) into dev/gfdl (c937208) will increase coverage by 0.03%.
The diff coverage is 3.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1499      +/-   ##
============================================
+ Coverage     29.01%   29.04%   +0.03%     
============================================
  Files           237      237              
  Lines         71784    71626     -158     
============================================
- Hits          20826    20807      -19     
+ Misses        50958    50819     -139     
Impacted Files Coverage Δ
src/ALE/MOM_regridding.F90 21.45% <0.00%> (ø)
src/core/MOM.F90 58.99% <0.00%> (+0.39%) ⬆️
src/core/MOM_barotropic.F90 37.11% <0.00%> (ø)
src/core/MOM_dynamics_split_RK2.F90 61.08% <0.00%> (+1.48%) ⬆️
src/core/MOM_dynamics_unsplit.F90 65.56% <0.00%> (ø)
src/core/MOM_dynamics_unsplit_RK2.F90 64.70% <0.00%> (ø)
src/core/MOM_grid.F90 61.68% <ø> (ø)
src/core/MOM_variables.F90 28.57% <0.00%> (ø)
src/core/MOM_verticalGrid.F90 70.21% <ø> (ø)
src/framework/MOM_checksums.F90 64.71% <0.00%> (+0.07%) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c937208...55876e8. Read the comment docs.

@marshallward
Copy link
Collaborator

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13646 ✔️

Copy link
Collaborator

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve any PR that removes semicolons!

@marshallward marshallward merged commit 2336727 into mom-ocean:dev/gfdl Sep 24, 2021
@Hallberg-NOAA Hallberg-NOAA deleted the allocate_with_source branch November 22, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants