Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct logical associated with NW2 tracers #1518

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Correct logical associated with NW2 tracers #1518

merged 1 commit into from
Oct 13, 2021

Conversation

adcroft
Copy link
Collaborator

@adcroft adcroft commented Oct 12, 2021

  • @klindsay28 spotted two issues for the NW2 tracers
    1. Use of the wrong logical variable
    2. Incorrect comment
  • Using the wrong logical meant that the ideal age pacakge was being called in addition to the NW2 package, but did not affect the NW2 tracers themselves.

- @klindsay28 spotted two issues for the NW2 tracers
  1. Use of the wrong logical variable
  2. Incorrect comment
- Using the wrong logical meant that the ideal age pacakge was being
  called in addition to the NW2 package, but did not affect the NW2
  tracers themselves.
@adcroft adcroft added the bug label Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #1518 (554c8a0) into dev-gfdl-main-candidate-2021-10-04 (de7a771) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           dev-gfdl-main-candidate-2021-10-04    #1518   +/-   ##
===================================================================
  Coverage                               29.06%   29.06%           
===================================================================
  Files                                     237      237           
  Lines                                   71643    71643           
===================================================================
  Hits                                    20823    20823           
  Misses                                  50820    50820           
Impacted Files Coverage Δ
src/tracer/MOM_tracer_flow_control.F90 51.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de7a771...554c8a0. Read the comment docs.

@Hallberg-NOAA
Copy link
Collaborator

I agree that these changes are correct and should be merged in.

@marshallward marshallward merged commit ecf88c6 into mom-ocean:dev-gfdl-main-candidate-2021-10-04 Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants