User/z1l/remove edge arrays #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavo-marques
pushed a commit
to gustavo-marques/MOM6
that referenced
this pull request
Mar 2, 2018
…_20feb2018 Merge dev/master 20 feb. 2018
Hallberg-NOAA
pushed a commit
to marshallward/MOM6
that referenced
this pull request
Jan 6, 2022
* Hydrostatic initialization in ice cavities
- Iteratively solve for the initial ice shelf displacement
in cavities by calculating the pressure at the current
displacement depth using the unperturbed profile.
- This change should obsolete TRIM_IC_FOR_PSURF and DEPRESS_INITIAL_SURFACE for
ice shelf applications and should work for arbitrary equations of state.
- Existing implementations (e.g. ISOMIP) should turn off the above options
in order to exercise this feature.
- This code change should not impact non ice-shelf configurations
or those with either of the above two options.
* Addresses a number of issues identified in code review.
* add appropriate intent to ice_shelf_query
* fix unit scaling comments
Co-authored-by: Marshall Ward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove type edgeValueArrays and edgeValueArrays for reproducing ability between different number of threads. Also remove any argument using these two types. Also changed some of regridding_CS and remapping_CS type argument from intent(inout) to intent(in).