Add a default, empty config object for DateTime, Duration, and Interv…

…al constructors
moment · Jun 28, 2024 · dfbd8d9 · dfbd8d9
1 parent cea7b5f
commit dfbd8d9
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 3 deletions.
diff --git a/src/datetime.js b/src/datetime.js
@@ -513,7 +513,7 @@ export default class DateTime {
   /**
    * @access private
    */
-  constructor(config) {
+  constructor(config = {}) {
     const zone = config.zone || Settings.defaultZone;
 
     let invalid =

diff --git a/src/duration.js b/src/duration.js
@@ -217,7 +217,7 @@ export default class Duration {
   /**
    * @private
    */
-  constructor(config) {
+  constructor(config = {}) {
     const accurate = config.conversionAccuracy === "longterm" || false;
     let matrix = accurate ? accurateMatrix : casualMatrix;
 

diff --git a/src/interval.js b/src/interval.js
@@ -40,7 +40,7 @@ export default class Interval {
   /**
    * @private
    */
-  constructor(config) {
+  constructor(config = {}) {
     /**
      * @access private
      */

diff --git a/test/datetime/create.test.js b/test/datetime/create.test.js
@@ -9,6 +9,13 @@ const withDefaultLocale = Helpers.withDefaultLocale,
   withthrowOnInvalid = Helpers.setUnset("throwOnInvalid"),
   withDefaultZone = Helpers.withDefaultZone;
 
+//------
+// new
+//------
+test("Default constructor works", () => {
+  expect(() => new DateTime()).not.toThrow();
+});
+
 //------
 // .now()
 //------

diff --git a/test/duration/create.test.js b/test/duration/create.test.js
@@ -2,6 +2,13 @@
 
 import { Duration } from "../../src/luxon";
 
+//------
+// new
+//------
+test("Default constructor works", () => {
+  expect(() => new Duration()).not.toThrow();
+});
+
 //------
 // .fromObject()
 //-------

diff --git a/test/interval/create.test.js b/test/interval/create.test.js
@@ -4,6 +4,13 @@ import Helpers from "../helpers";
 
 const withThrowOnInvalid = Helpers.setUnset("throwOnInvalid");
 
+//------
+// new
+//------
+test("Default constructor works", () => {
+  expect(() => new Interval()).not.toThrow();
+});
+
 //------
 // .fromObject()
 //-------