Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2015c and 2015d data updates #214

Merged
merged 1 commit into from
May 13, 2015
Merged

Conversation

timrwood
Copy link
Member

See #205

@timrwood timrwood mentioned this pull request May 11, 2015
@@ -774,62 +718,6 @@
1403816400000,
1406844000000,
1411678800000,
1429826400000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timrwood - Why are the "untils" being truncated here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also included 2015d which removed DST in Egypt. http://mm.icann.org/pipermail/tz-announce/2015-April/000031.html

@mattjohnsonpint
Copy link
Contributor

I still see way more data updates in the unpacked files than are actually in the tzdb releases (as far as I can tell). Are you just running grunt data:2014c or something different or more than that?

FYI - that's all I did, and was on a clean Ubuntu box when I did #205, so it's not a line-endings issue. Currently we actually can't build the TZ files on Windows due to dependencies on zic and zdump.

Also - the contributing guide describes how to compile these files, but it doesn't describe how to build the moment-timezone-2010-2020.js and moment-timezone-all-years.js files to update the moment-timezone home page - which currently still references 2014j. We need to get this all straightened out. (please)

@mattjohnsonpint
Copy link
Contributor

Merging as is, though I could still use additional instruction in this area. Thanks.

mattjohnsonpint added a commit that referenced this pull request May 13, 2015
2015c and 2015d data updates
@mattjohnsonpint mattjohnsonpint merged commit 339f46c into moment:develop May 13, 2015
@timrwood
Copy link
Member Author

@mj1856, moment-timezone-2010-2020.js and moment-timezone-all-years.js are built with the grunt release command.

@timrwood timrwood deleted the 2015c branch May 13, 2015 19:41
@synotna
Copy link

synotna commented May 19, 2015

Is there an ETA of these updates being released?

@timrwood timrwood mentioned this pull request May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants