Handle uncommon output from Date#toTimeString. #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Just curious, what is the expected output going to be now? Is it just going to return In either case, can the tests being added here cover what the return value should be? |
|
The expected output is that A test would be good, but this class isn't exposed publicly at all, so it currently isn't possible to test the exact output. Moving to ES6 modules as noted in #298 would make explicit tests for this possible. |
timrwood
added a commit
that referenced
this pull request
Mar 1, 2016
Handle uncommon output from Date#toTimeString.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #294