prefer nodejs to amd declaration Issue #572 #573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CharlesWall
changed the title
|
Please note that preferring nodejs style declaration is consistent with the way moment works. |
|
As there are conflicts, I picked your code and included into this release 0.5.18 |
|
Aw man. Picked my code? So I'm not in the commit history? :-( |
timopollmeier
pushed a commit
to timopollmeier/gsa
that referenced
this pull request
Jun 26, 2018
Version 0.5.18 changed moment-timezone to prefer node modules over amd modules (moment/moment-timezone#573) which fixed using and loading locales with moment-timezone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.