Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to timezone database 2022b #996

Closed
wants to merge 3 commits into from

Conversation

repl-angrez-singh
Copy link

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 15, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: repl-angrez-singh (d8b0bd8)

@gilmoreorless gilmoreorless mentioned this pull request Aug 15, 2022
Copy link

@nickosepulveda nickosepulveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chile, the time change is approaching very soon. We are waiting for the new version to install it.

@moranza
Copy link

moranza commented Aug 17, 2022

@nickosepulveda Can the pr be merged? We would like to have the 0.5.35 version before 4.9 :)

@jasonmobley
Copy link

@ellenaua we could use your help getting this change merged and a new release published ASAP due to the DST policy change in Chile mentioned above by others.

https://www.timeanddate.com/news/time/chile-dst-delay-2022.html

@joebehymer
Copy link

Hello, we would very much appreciate this getting merged as soon as possible.

We are considering whether to copy this branch into a local fork of moment-timezone to work around this. Getting this merged will save us quite some time. Cheers.

@alexmaie
Copy link

Hi, we are affected by the timezone change in Chile which was announced two weeks ago. We can't patch our system without 2022c

@lhorie
Copy link

lhorie commented Aug 24, 2022

@alexmaie I went ahead and published an unofficial fork including 2022c here https://www.npmjs.com/package/moment-timezone-fork

@alexmaie
Copy link

@lhorie thanks for the update !!!

@ichernev
Copy link
Contributor

Hey, 0.5.36 is now released (featuring 2022c tz data).

@nickosepulveda the way moment-timezone works is that you have code and you have data, and you can always provide your own (newer) data if you'd like. So next time, instead of waiting for somebody on the internet to fix things in your codebase, you can compile any data you want with grunt data:2022c (for example) and then put data/packed/latest.json somewhere accessible on your server, then fetch it, parse it and pass it to moment.tz.load(dataObject).

There is also little need to provide a fork just for an updated data file, but ... whatever floats your boat I guess.

@ichernev ichernev closed this Aug 25, 2022
@joebehymer
Copy link

Thank you @ichernev

Maybe we can all take this as a wake up call to migrate away from moment :)

@lhorie
Copy link

lhorie commented Aug 25, 2022

@ichernev For context, we maintain a large monorepo w/ hundreds of services owned by different teams, so loading data files via code changes and then subsequently coordinating deployments for all the services is not really feasible, especially on short notice.

If using grunt data + .tz.load(...) is the recommendation (even after considering that moment-timezone is used in server, browser and isomorphic contexts, and considering bundle size concerns), it might be a good idea to document that.

Alternatively, leveraging Intl like date-fns does might be another option, if the maintainers are still willing to make code changes of that magnitude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants