Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] Print console warning when setting non-existent locales #4085

Merged
merged 5 commits into from
Mar 2, 2018
Merged

[misc] Print console warning when setting non-existent locales #4085

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf879e7
Dont silently fail setting new locale when it isnt available
asulaiman Jul 26, 2017
c2d6135
added missing semicolon
asulaiman Jul 26, 2017
596cab7
Added console warn check.
asulaiman Aug 3, 2017
4a6fe5f
Fixed if condition.
asulaiman Aug 3, 2017
08da1ad
Add space
marwahaha Dec 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/lib/locale/locales.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ export function getSetGlobalLocale (key, values) {
// moment.duration._locale = moment._locale = data;
globalLocale = data;
}
else {
if ((typeof console !== 'undefined') && console.warn) {
//warn user if arguments are passed but the locale could not be set
console.warn('Locale ' + key + ' not found. Did you forget to load it?');
}
}
}

return globalLocale._abbr;
Expand Down