Merge pull request #449 from momentohq/feat/add-listLength-to-list-mo…

…difications
momentohq · Jun 8, 2023 · b5bbb03 · b5bbb03
2 parents 076faff + d86cee6
commit b5bbb03
Show file tree

Hide file tree

Showing 7 changed files with 151 additions and 16 deletions.
diff --git a/src/Momento.Sdk/Internal/ScsDataClient.cs b/src/Momento.Sdk/Internal/ScsDataClient.cs
@@ -1169,7 +1169,7 @@ private async Task<CacheListRetainResponse> SendListRetainAsync(string cacheName
             return this._logger.LogTraceCollectionRequestError(REQUEST_TYPE_LIST_RETAIN, cacheName, listName, new CacheListRetainResponse.Error(_exceptionMapper.Convert(e, metadata)));
         }
 
-        return this._logger.LogTraceCollectionRequestSuccess(REQUEST_TYPE_LIST_RETAIN, cacheName, listName, new CacheListRetainResponse.Success());
+        return this._logger.LogTraceCollectionRequestSuccess(REQUEST_TYPE_LIST_RETAIN, cacheName, listName, new CacheListRetainResponse.Success(response));
     }
 
     const string REQUEST_TYPE_LIST_REMOVE_VALUE = "LIST_REMOVE_VALUE";
@@ -1180,19 +1180,20 @@ private async Task<CacheListRemoveValueResponse> SendListRemoveValueAsync(string
             ListName = listName.ToByteString(),
             AllElementsWithValue = value
         };
+        _ListRemoveResponse response;
         var metadata = MetadataWithCache(cacheName);
 
         try
         {
             this._logger.LogTraceExecutingCollectionRequest(REQUEST_TYPE_LIST_REMOVE_VALUE, cacheName, listName, value, null);
-            await this.grpcManager.Client.ListRemoveAsync(request, new CallOptions(headers: MetadataWithCache(cacheName), deadline: CalculateDeadline()));
+            response = await this.grpcManager.Client.ListRemoveAsync(request, new CallOptions(headers: MetadataWithCache(cacheName), deadline: CalculateDeadline()));
         }
         catch (Exception e)
         {
             return this._logger.LogTraceCollectionRequestError(REQUEST_TYPE_LIST_REMOVE_VALUE, cacheName, listName, value, null, new CacheListRemoveValueResponse.Error(_exceptionMapper.Convert(e, metadata)));
         }
 
-        return this._logger.LogTraceCollectionRequestSuccess(REQUEST_TYPE_LIST_REMOVE_VALUE, cacheName, listName, value, null, new CacheListRemoveValueResponse.Success());
+        return this._logger.LogTraceCollectionRequestSuccess(REQUEST_TYPE_LIST_REMOVE_VALUE, cacheName, listName, value, null, new CacheListRemoveValueResponse.Success(response));
     }
 
     const string REQUEST_TYPE_LIST_LENGTH = "LIST_LENGTH";

diff --git a/src/Momento.Sdk/Responses/CacheListFetchResponse.cs b/src/Momento.Sdk/Responses/CacheListFetchResponse.cs
@@ -50,6 +50,11 @@ public class Hit : CacheListFetchResponse
         protected readonly Lazy<IList<string>> _stringList;
 #pragma warning restore 1591
 
+        /// <summary>
+        /// The length of the list.
+        /// </summary>
+        public int ListLength { get; private set; }
+
         /// <summary>
         /// 
         /// </summary>
@@ -66,6 +71,8 @@ public Hit(_ListFetchResponse response)
             {
                 return new List<string>(values.Select(v => v.ToStringUtf8()));
             });
+
+            ListLength = values.Count;
         }
 
         /// <summary>
@@ -83,7 +90,7 @@ public override string ToString()
         {
             var stringRepresentation = String.Join(", ", ValueListString.Select(value => $"\"{value}\""));
             var byteArrayRepresentation = String.Join(", ", ValueListByteArray.Select(value => $"\"{value.ToPrettyHexString()}\""));
-            return $"{base.ToString()}: ValueListString: [{stringRepresentation.Truncate()}] ValueListByteArray: [{byteArrayRepresentation.Truncate()}]";
+            return $"{base.ToString()}: ValueListString: [{stringRepresentation.Truncate()}] ValueListByteArray: [{byteArrayRepresentation.Truncate()}] ListLength: {ListLength}";
         }
     }
 

diff --git a/src/Momento.Sdk/Responses/CacheListPopBackResponse.cs b/src/Momento.Sdk/Responses/CacheListPopBackResponse.cs
@@ -44,13 +44,19 @@ public class Hit : CacheListPopBackResponse
         protected readonly ByteString value;
 #pragma warning restore 1591
 
+        /// <summary>
+        /// The length of the list post-pop (and post-truncate, if that applies).
+        /// </summary>
+        public int ListLength { get; private set; }
+
         /// <summary>
         /// 
         /// </summary>
         /// <param name="response">The cache response.</param>
         public Hit(_ListPopBackResponse response)
         {
             this.value = response.Found.Back;
+            ListLength = checked((int)response.Found.ListLength);
         }
 
         /// <summary>
@@ -69,7 +75,7 @@ public byte[] ValueByteArray
         /// <inheritdoc />
         public override string ToString()
         {
-            return $"{base.ToString()}: ValueString: \"{ValueString.Truncate()}\" ValueByteArray: \"{ValueByteArray.ToPrettyHexString().Truncate()}\"";
+            return $"{base.ToString()}: ValueString: \"{ValueString.Truncate()}\" ValueByteArray: \"{ValueByteArray.ToPrettyHexString().Truncate()}\" ListLength: {ListLength}";
         }
     }
 

diff --git a/src/Momento.Sdk/Responses/CacheListPopFrontResponse.cs b/src/Momento.Sdk/Responses/CacheListPopFrontResponse.cs
@@ -44,13 +44,19 @@ public class Hit : CacheListPopFrontResponse
         protected readonly ByteString value;
 #pragma warning restore 1591
 
+        /// <summary>
+        /// The length of the list post-pop (and post-truncate, if that applies).
+        /// </summary>
+        public int ListLength { get; private set; }
+
         /// <summary>
         /// 
         /// </summary>
         /// <param name="response">The cache response</param>
         public Hit(_ListPopFrontResponse response)
         {
             this.value = response.Found.Front;
+            ListLength = checked((int)response.Found.ListLength);
         }
 
         /// <summary>
@@ -69,7 +75,7 @@ public byte[] ValueByteArray
         /// <inheritdoc />
         public override string ToString()
         {
-            return $"{base.ToString()}: ValueString: \"{ValueString.Truncate()}\" ValueByteArray: \"{ValueByteArray.ToPrettyHexString().Truncate()}\"";
+            return $"{base.ToString()}: ValueString: \"{ValueString.Truncate()}\" ValueByteArray: \"{ValueByteArray.ToPrettyHexString().Truncate()}\" ListLength: {ListLength}";
         }
     }
 

diff --git a/src/Momento.Sdk/Responses/CacheListRemoveValueResponse.cs b/src/Momento.Sdk/Responses/CacheListRemoveValueResponse.cs
@@ -1,4 +1,5 @@
-using Momento.Sdk.Exceptions;
+using Momento.Protos.CacheClient;
+using Momento.Sdk.Exceptions;
 
 namespace Momento.Sdk.Responses;
 
@@ -32,6 +33,27 @@ public abstract class CacheListRemoveValueResponse
     /// <include file="../docs.xml" path='docs/class[@name="Success"]/description/*' />
     public class Success : CacheListRemoveValueResponse
     {
+        /// <summary>
+        /// The length of the list post-remove operation.
+        /// </summary>
+        public int ListLength { get; private set; }
+
+        /// <summary>
+        /// 
+        /// </summary>
+        /// <param name="response">The cache response</param>
+        public Success(_ListRemoveResponse response)
+        {
+            if (response.ListCase == _ListRemoveResponse.ListOneofCase.Found) {
+                ListLength = checked((int)response.Found.ListLength);
+            }
+        }
+
+        /// <inheritdoc />
+        public override string ToString()
+        {
+            return $"{base.ToString()}: ListLength: {ListLength}";
+        }
     }
 
     /// <include file="../docs.xml" path='docs/class[@name="Error"]/description/*' />

diff --git a/src/Momento.Sdk/Responses/CacheListRetainResponse.cs b/src/Momento.Sdk/Responses/CacheListRetainResponse.cs
@@ -1,4 +1,5 @@
-using Momento.Sdk.Exceptions;
+using Momento.Protos.CacheClient;
+using Momento.Sdk.Exceptions;
 
 namespace Momento.Sdk.Responses;
 
@@ -32,6 +33,25 @@ public abstract class CacheListRetainResponse
     /// <include file="../docs.xml" path='docs/class[@name="Success"]/description/*' />
     public class Success : CacheListRetainResponse
     {
+        /// <summary>
+        /// The length of the list post-retain operation.
+        /// </summary>
+        public int ListLength { get; private set; }
+
+        /// <summary>
+        /// 
+        /// </summary>
+        /// <param name="response">The cache response</param>
+        public Success(_ListRetainResponse response)
+        {
+            ListLength = checked((int)response.Found.ListLength);
+        }
+
+        /// <inheritdoc />
+        public override string ToString()
+        {
+            return $"{base.ToString()}: ListLength: {ListLength}";
+        }
     }
 
     /// <include file="../docs.xml" path='docs/class[@name="Error"]/description/*' />