Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add dictionary set and fetch overloads #120

Merged
merged 5 commits into from
Aug 25, 2022
Merged

chore: add dictionary set and fetch overloads #120

merged 5 commits into from
Aug 25, 2022

Conversation

malandis
Copy link
Contributor

@malandis malandis commented Aug 25, 2022 •
edited
Loading

Add overloads for DictionarySet and DictionarySetBatch to accept string fields and byte[] values. Also support marshalling DictionaryFetch results to Dictionary<string, byte[]>.

Closes #119

bruuuuuuuce
bruuuuuuuce approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@bruuuuuuuce bruuuuuuuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@malandis malandis merged commit 293494a into main Aug 25, 2022
@malandis malandis deleted the chore/add-dictionary-set-and-fetch-overloads branch August 25, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruuuuuuuce bruuuuuuuce bruuuuuuuce approved these changes

@eaddingtonwhite eaddingtonwhite Awaiting requested review from eaddingtonwhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DictionarySet/DictionaryFetch with string-bytes C#
2 participants
@malandis @bruuuuuuuce