Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stub parameter to ListPush to truncate after size. #123

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

malandis
Copy link
Contributor

Add an optional truncateTailToSize (truncateHeadToSize) to LishPushFront (ListPushBack). This argument will trigger the list to be trimmed on the opposite end of the push if the size exceeds the specified value. This PR adds the argument to the method signatures as well as checks that it is strictly positive. A future PR will make this functional.

Progress towards #122 .

Copy link
Member

@eaddingtonwhite eaddingtonwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this param not used yet I think ok for now if wanting to get infront of customer for feed back. Left one comment about additional tests for happy path but assuming you will be adding those in follow up pr w/ impl?

IncubatingIntegrationTest/ListTest.cs Show resolved Hide resolved
@malandis malandis marked this pull request as ready for review August 26, 2022 18:09
@malandis malandis merged commit 3588719 into main Aug 26, 2022
@malandis malandis deleted the feat/list-push-with-truncate-stub branch August 26, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants