feat: release from release branch #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `cd.yaml` job so that we don't do a release on every commit. Introduces a new manual release job that we can use to decide when to do a release. Releases will come from the `release` branch rather than the `main` branch.
pgautier404
approved these changes
Sep 13, 2022
malandis
reviewed
Sep 13, 2022
Comment on lines
+25
to
+43
| - name: Build | ||
| run: | | ||
| dotnet build | ||
| shell: bash | ||
|
|
||
| - name: Unit Test | ||
| run: | | ||
| dotnet test tests/Unit/Momento.Sdk.Tests | ||
| shell: bash | ||
|
|
||
| - name: Integration Test | ||
| run: | | ||
| dotnet test tests/Integration/Momento.Sdk.Tests | ||
| shell: bash | ||
|
|
||
| - name: Incubating Integration Test | ||
| run: | | ||
| dotnet test tests/Integration/Momento.Sdk.Incubating.Tests | ||
| shell: bash |
There was a problem hiding this comment.
Not a blocker but is there an easy way in GH actions to dry duplicated steps, eg this block vs what's in ci.yaml
There was a problem hiding this comment.
it can be done. pete did some of it in the examples repo, see the .github/actions dir. I also have some re-usable actions in standards-and-practices.
malandis
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
cd.yamljob so that we don't do a release onevery commit. Introduces a new manual release job that we
can use to decide when to do a release. Releases will come
from the
releasebranch rather than themainbranch.