Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy dotnet examples from examples repo #148

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Conversation

cprice404
Copy link
Contributor

We are in the process of moving the examples out of the old examples repo and into the individual SDK repos. This commit copies the dotnet examples over; no changes.

Also copies over Pete's dependabot/examples CI work.

Updates the `cd.yaml` job so that we don't do a release on
every commit.  Introduces a new manual release job that we
can use to decide when to do a release.  Releases will come
from the `release` branch rather than the `main` branch.
We are in the process of moving the examples out of the old
examples repo and into the individual SDK repos.  This commit
copies the dotnet examples over; no changes.

Also copies over Pete's dependabot/examples CI work.
Copy link
Member

@eaddingtonwhite eaddingtonwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the copy pasta 🙇 🍝

Copy link
Contributor

@malandis malandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is dependabot still necessary now that the examples are in this repo and part of the CI workflow?

@cprice404
Copy link
Contributor Author

Is dependabot still necessary now that the examples are in this repo and part of the CI workflow?

yes, it enforces that the examples get tested with the latest binary release of the SDK when the SDK is released.

@malandis
Copy link
Contributor

Got it -- the release artifact vs in repo build difference!

Base automatically changed from release-from-release-branch to main September 14, 2022 00:54
@cprice404 cprice404 merged commit 9794827 into main Sep 14, 2022
@cprice404 cprice404 deleted the move-examples branch September 14, 2022 00:55
malandis added a commit that referenced this pull request Sep 15, 2022
This email action was missing from PR #148.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants