Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove value response name and list push length #149

Merged
merged 4 commits into from
Sep 13, 2022
Merged

fix: remove value response name and list push length #149

merged 4 commits into from
Sep 13, 2022

Conversation

malandis
Copy link
Contributor

@malandis malandis commented Sep 13, 2022 •
edited
Loading

This fixes two minor issues:

  1. The ListRemoveValue response had an out of date name. Changed to CacheListRemoveValue
  2. Added list length to the response for ListPushFront and ListPushBack

Closes #144

@malandis malandis marked this pull request as ready for review September 13, 2022 17:34
@malandis malandis merged commit 2889920 into main Sep 13, 2022
@malandis malandis deleted the fix/remove-value-response-name-and-list-push-length branch September 13, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eaddingtonwhite eaddingtonwhite eaddingtonwhite approved these changes

@bruuuuuuuce bruuuuuuuce Awaiting requested review from bruuuuuuuce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix listremoveall name and add list length to list push responses
2 participants
@malandis @eaddingtonwhite