chore: add initial simple loadgen #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an initial port of the simple load generator from the python/js SDKs. It will need some additional error handling, and we need to add a client-side max TPS flag, but should be usable for initial tuning work.
malandis
reviewed
Sep 16, 2022
Comment on lines
+351
to
+354
| /** | ||
| * Configures the Momento client to timeout if a request exceeds this limit. | ||
| * Momento client default is 5 seconds. | ||
| */ |
There was a problem hiding this comment.
Try using triple-front-slash /// for the C# docstrings
pgautier404
reviewed
Sep 17, 2022
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="6.0.0" /> | ||
| <PackageReference Include="Momento.Sdk" Version="0.27.1" /> |
There was a problem hiding this comment.
Current release is 0.29.0, which I'm now realizing probably affects the other examples as well. Not to mention that will be wrong as soon as we cut a new release, so you may want to set this to 0.29.1 if you plan to release for this.
There was a problem hiding this comment.
cool yeah i will update next time i'm in there but I don't think there are any perf-impacting changes in recent releases.
eaddingtonwhite
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an initial port of the simple load generator
from the python/js SDKs. It will need some additional error
handling, and we need to add a client-side max TPS flag, but
should be usable for initial tuning work.