Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flatten exception hierarchy #163

Merged
merged 1 commit into from
Sep 20, 2022
Merged

feat: flatten exception hierarchy #163

merged 1 commit into from
Sep 20, 2022

Conversation

pgautier404
Copy link
Contributor

Removed ClientSdkException and MomentoServiceException from the exception hierarchy and modified all subclasses to subclass SdkException instead. Added an UnknownException type to handle the fallthrough case in CacheExceptionMapper.

cprice404
cprice404 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:ty:

@pgautier404 pgautier404 merged commit ddfa8e1 into main Sep 20, 2022
@pgautier404 pgautier404 deleted the feat/flatten-exception-hierarchy branch September 20, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprice404 cprice404 cprice404 approved these changes

@malandis malandis Awaiting requested review from malandis

@eaddingtonwhite eaddingtonwhite Awaiting requested review from eaddingtonwhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgautier404 @cprice404