chore: wire up grpc settings from Configuration #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates our interface for the gRPC settings. The original version was built based on the specification doc that I wrote, which was in turn based on tuning work done with our JavaScript SDK. In .NET it turns out that the settings we were configuring for JS aren't relevant, and furthermore the .NET gRPC library only exposes a much more strongly-typed interface into what gRPC channel options you can configure. This is largely what we were trying to accomplish with our abstraction, so it makes more sense for this SDK to just expose the .NET one directly, which is what we do in this commit.
malandis
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates our interface for the gRPC settings.
The original version was built based on the specification
doc that I wrote, which was in turn based on tuning work
done with our JavaScript SDK. In .NET it turns out that
the settings we were configuring for JS aren't relevant,
and furthermore the .NET gRPC library only exposes a much
more strongly-typed interface into what gRPC channel options
you can configure. This is largely what we were trying
to accomplish with our abstraction, so it makes more sense
for this SDK to just expose the .NET one directly, which
is what we do in this commit.