fix: handle AggregateExceptions from task continuations #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Middleware code, if you need to modify the response before it makes it back out to the caller, you need to use `Task.ContinueWith`. However, if an exception is thrown while such a Middleware is in the stack, the exception will get wrapped in an AggregateException. Prior to this commit our CacheExceptionMapper would treat this as an unknown error and we would lose our desired status code mapping. This commit unwraps AggregateExceptions before the mapping so that the error codes will be correct. It also adds debug logs to the exception mapper so that we can see what's going wrong if other exception types fail to map properly in the future.
cprice404
force-pushed
the
handle-continuation-exception-types
branch
from
ca4f6eb
to
9214bb4
Compare
|
had to rebase this one |
poppoerika
approved these changes
Oct 7, 2022
pgautier404
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Middleware code, if you need to modify the response before it
makes it back out to the caller, you need to use
Task.ContinueWith.However, if an exception is thrown while such a Middleware is
in the stack, the exception will get wrapped in an AggregateException.
Prior to this commit our CacheExceptionMapper would treat this as
an unknown error and we would lose our desired status code mapping.
This commit unwraps AggregateExceptions before the mapping so that
the error codes will be correct.
It also adds debug logs to the exception mapper so that we can
see what's going wrong if other exception types fail to map
properly in the future.