-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update docstrings to follow best practices #284
Changes from 2 commits
ebc701a
ce89ce2
58208f5
5afa0d5
ac4c729
3975a7a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,16 +12,47 @@ namespace Momento.Sdk.Config; | |
/// </summary> | ||
public interface IConfiguration | ||
{ | ||
/// <inheritdoc cref="Momento.Sdk.Config.IConfiguration.LoggerFactory" /> | ||
public ILoggerFactory LoggerFactory { get; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks like it's trying to inherit from itself. This should (I think) reference There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for pointing it out! |
||
|
||
/// <inheritdoc cref="Momento.Sdk.Config.Retry.IRetryStrategy" /> | ||
public IRetryStrategy RetryStrategy { get; } | ||
/// <inheritdoc cref="Momento.Sdk.Config.Middleware.IMiddleware" /> | ||
public IList<IMiddleware> Middlewares { get; } | ||
/// <inheritdoc cref="Momento.Sdk.Config.Transport.ITransportStrategy" /> | ||
public ITransportStrategy TransportStrategy { get; } | ||
|
||
/// <summary> | ||
/// Creates a new instance of the Configuration object, updated to use the specified logger factory. | ||
/// </summary> | ||
/// <param name="loggerFactory">This is responsible for configuraing logging.</param> | ||
/// <returns>Configuration object with custom logging provided</returns> | ||
public IConfiguration WithLoggerFactory(ILoggerFactory loggerFactory); | ||
|
||
/// <summary> | ||
/// Creates a new instance of the Configuration object, updated to use the specified retry strategy. | ||
/// </summary> | ||
/// <param name="retryStrategy">Defines a contract for how and when to retry a request</param> | ||
/// <returns>Configuration object with custom retry strategy provided</returns> | ||
public IConfiguration WithRetryStrategy(IRetryStrategy retryStrategy); | ||
|
||
/// <summary> | ||
/// Creates a new instance of the Configuration object, updated to use the specified middlewares. | ||
/// </summary> | ||
/// <param name="middlewares">The Middleware interface allows the Configuration to provide a higher-order function that wraps all requests.</param> | ||
/// <returns>Configuration object with custom middlewares provided</returns> | ||
public IConfiguration WithMiddlewares(IList<IMiddleware> middlewares); | ||
|
||
/// <summary> | ||
/// Creates a new instance of the Configuration object, updated to use the specified transport strategy. | ||
/// </summary> | ||
/// <param name="transportStrategy">This is responsible for configuring network tunables.</param> | ||
/// <returns>Configuration object with custom transport strategy provided</returns> | ||
public IConfiguration WithTransportStrategy(ITransportStrategy transportStrategy); | ||
|
||
/// <summary> | ||
/// Creates a new instance of the Configuration object, updated to use the specified client timeout. | ||
/// </summary> | ||
/// <param name="clientTimeoutMillis">The amount of time to wait before cancelling the request.</param> | ||
/// <returns>Configuration object with custom client timeout provided</returns> | ||
public IConfiguration WithClientTimeoutMillis(uint clientTimeoutMillis); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These
see
tags need to be closed:<see cref="foo" />