chore: Make header names that always need to be sent constants #38
Conversation
Momento/HeaderInterceptor.cs
Outdated
|
|
||
| namespace MomentoSdk | ||
| { | ||
| class Header | ||
| { | ||
| public readonly List<string> onceOnlyHeaders = new List<string>{"Agent"}; |
There was a problem hiding this comment.
Thank you for making this change.
Can you also make "Agent" and "Authorization" constants in this class and use them here and where you are actually setting the headers?
Momento/HeaderInterceptor.cs
Outdated
|
|
||
| namespace MomentoSdk | ||
| { | ||
| class Header | ||
| { | ||
| private const string Agent = "Agent"; |
There was a problem hiding this comment.
I dont think we should add this in each file. Define once and reference in each class.
e.g. drop the constant private here
const string AGENT_KEY = "Agent";
const string AUTHORIZATION_KEY = "Authorization";
And then in DataGrpcManager reference in Headers.AGENT_KEY
There was a problem hiding this comment.
And just one note, you probably should looking up naming conventions for C# for constants AGENT_KEY is what is done in Java. So, check the appropriate C# guideline. May be it is exactly how you have defined here.
There was a problem hiding this comment.
It seems like FullProductName is its naming convention for constants.
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/const
This is a follow-up pr for the implementation option 2 mentioned here.